Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758628AbZFJB4h (ORCPT ); Tue, 9 Jun 2009 21:56:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754822AbZFJB4c (ORCPT ); Tue, 9 Jun 2009 21:56:32 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:41728 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754459AbZFJB4b (ORCPT ); Tue, 9 Jun 2009 21:56:31 -0400 Date: Tue, 9 Jun 2009 21:56:32 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Xiao Guangrong cc: Frederic Weisbecker , Ingo , LKML , netdev@vger.kernel.org, David Miller , Neil Horman Subject: Re: [PATCH RESEND] ftrace: change the export format of trace_kfree_skb() In-Reply-To: <4A2F0F1D.7010101@cn.fujitsu.com> Message-ID: References: <4A2DF91F.7030906@cn.fujitsu.com> <20090609182730.GA6057@nowhere> <4A2F0F1D.7010101@cn.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 35 On Wed, 10 Jun 2009, Xiao Guangrong wrote: > > > Frederic Weisbecker wrote: > > > > > Acked-by: Frederic Weisbecker > > > > Would you also be interested in adding the conversion from raw numeric protocol > > to its name defined in include/linux/if_ether.h > > > Hi Frederic: > > OK, I'll do it. > > > I guess __print_flags() can be used for that. > > > > Thanks for you suggestion. > IMHO, __print_symbolic() is more suitable for this. :-) BTW, you might want to take a look at what is coming: http://marc.info/?l=linux-kernel&m=124458472931447&w=2 -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/