Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756857AbZFJHqb (ORCPT ); Wed, 10 Jun 2009 03:46:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755753AbZFJHqW (ORCPT ); Wed, 10 Jun 2009 03:46:22 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:60307 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754867AbZFJHqW (ORCPT ); Wed, 10 Jun 2009 03:46:22 -0400 Message-ID: <4A2F646A.8070403@cn.fujitsu.com> Date: Wed, 10 Jun 2009 15:44:42 +0800 From: Gui Jianfeng User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Vivek Goyal CC: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, dm-devel@redhat.com, jens.axboe@oracle.com, nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com, mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it, ryov@valinux.co.jp, fernando@oss.ntt.co.jp, s-uchida@ap.jp.nec.com, taka@valinux.co.jp, jmoyer@redhat.com, dhaval@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com, righi.andrea@gmail.com, m-ikeda@ds.jp.nec.com, jbaron@redhat.com, agk@redhat.com, snitzer@redhat.com, akpm@linux-foundation.org, peterz@infradead.org Subject: Re: [PATCH 17/19] io-controller: Support per cgroup per device weights and io class References: <1244513342-11758-1-git-send-email-vgoyal@redhat.com> <1244513342-11758-18-git-send-email-vgoyal@redhat.com> In-Reply-To: <1244513342-11758-18-git-send-email-vgoyal@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 49 Vivek Goyal wrote: ... > > @@ -1233,6 +1254,8 @@ struct io_group *io_group_chain_alloc(struct request_queue *q, void *key, > elv_get_iog(iog); > > iog->iocg_id = css_id(&iocg->css); > + io_group_init_entity(iocg, iog, iog->dev); Hi Vivek, A regression occurs in io.policy handling. IO Controller completely stops working when i use this interface. Make sure that we initialize entity after iog->dev is setting up properly. Signed-off-by: Gui Jianfeng --- block/elevator-fq.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block/elevator-fq.c b/block/elevator-fq.c index 6b30c36..a516dce 100644 --- a/block/elevator-fq.c +++ b/block/elevator-fq.c @@ -1451,7 +1451,6 @@ struct io_group *io_group_chain_alloc(struct request_queue *q, void *key, elv_get_iog(iog); iog->iocg_id = css_id(&iocg->css); - io_group_init_entity(iocg, iog, iog->dev); iog->my_entity = &iog->entity; if (bio) { @@ -1459,6 +1458,8 @@ struct io_group *io_group_chain_alloc(struct request_queue *q, void *key, iog->dev = MKDEV(disk->major, disk->first_minor); } + io_group_init_entity(iocg, iog, iog->dev); + blk_init_request_list(&iog->rl); #ifdef CONFIG_DEBUG_GROUP_IOSCHED io_group_path(iog, iog->path, sizeof(iog->path)); -- 1.5.4.rc3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/