Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757831AbZFJNCS (ORCPT ); Wed, 10 Jun 2009 09:02:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754667AbZFJNCK (ORCPT ); Wed, 10 Jun 2009 09:02:10 -0400 Received: from thunk.org ([69.25.196.29]:48807 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818AbZFJNCJ (ORCPT ); Wed, 10 Jun 2009 09:02:09 -0400 Date: Wed, 10 Jun 2009 09:01:27 -0400 From: Theodore Tso To: =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker Cc: Ingo Molnar , Steven Rostedt , linux-kernel@vger.kernel.org, Andrew Morton , Minchan Kim , Mel Gorman , Christoph Hellwig , Rik van Riel , Pekka Enberg , Peter Zijlstra , Mathieu Desnoyers , Lai Jiangshan , Zhaolei , KOSAKI Motohiro , Jason Baron , Jiaying Zhang , Tom Zanussi , Xiao Guangrong Subject: Re: [PATCH 00/11] [GIT PULL] more updates for the tag format Message-ID: <20090610130127.GA6647@mit.edu> Mail-Followup-To: Theodore Tso , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Ingo Molnar , Steven Rostedt , linux-kernel@vger.kernel.org, Andrew Morton , Minchan Kim , Mel Gorman , Christoph Hellwig , Rik van Riel , Pekka Enberg , Peter Zijlstra , Mathieu Desnoyers , Lai Jiangshan , Zhaolei , KOSAKI Motohiro , Jason Baron , Jiaying Zhang , Tom Zanussi , Xiao Guangrong References: <20090610054206.510574695@goodmis.org> <20090610092644.GA20889@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@mit.edu X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 27 On Wed, Jun 10, 2009 at 01:11:40PM +0200, Fr?d?ric Weisbecker wrote: > Well, indeed I had worries, but I discussed about it with Steven and > now I actually > think this new tag format is much more powerful than printf style. > It brings a cleaner, and much higher level way to control the data exports. > > But it would be nice to read some opinions from end users (end > developers) of TRACE_EVENT(). Maybe I'm missing something, but looks like the this new format, while simpler and easier to read, doesn't have support for using a more complicated C expression as a printk argument. For example: TP_printk("dev %s ino %lu mode %d uid %u gid %u blocks %llu", jbd2_dev_to_name(__entry->dev), __entry->ino, __entry->mode, __entry->uid, __entry->gid, __entry->blocks) How should I handle the "jbd2_dev_to_name(__entry->dev)" argument to TP_printk? The whole point of calling jbd2_dev_to_name() at TP_printk time is to not bloat the ring buffer with a 32 byte devname. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/