Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759794AbZFJOv7 (ORCPT ); Wed, 10 Jun 2009 10:51:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758081AbZFJOvw (ORCPT ); Wed, 10 Jun 2009 10:51:52 -0400 Received: from mail-fx0-f213.google.com ([209.85.220.213]:48682 "EHLO mail-fx0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756886AbZFJOvw convert rfc822-to-8bit (ORCPT ); Wed, 10 Jun 2009 10:51:52 -0400 MIME-Version: 1.0 In-Reply-To: <1244644064-32737-1-git-send-email-tom.leiming@gmail.com> References: <1244644064-32737-1-git-send-email-tom.leiming@gmail.com> From: Kay Sievers Date: Wed, 10 Jun 2009 16:51:19 +0200 Message-ID: Subject: Re: [PATCH 1/2] driver core: introduce devtmpfs_wait_for_dev() To: tom.leiming@gmail.com Cc: greg@kroah.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 990 Lines: 27 On Wed, Jun 10, 2009 at 16:27, wrote: > This patch introduces devtmpfs_wait_for_dev(), which is based on devtmpfs > and can be used to remove polling for root device before mounting rootfs. > +       nodename = dev_path + 5; I guess this is to strip "/dev/". Devtmpfs has no clue where it is mounted, it is just a simple superblock. I guess, the caller would better pass a relative path to it, to keep all the implicit lookup magic with root=/dev/* in one place where the commandline parsing and mounting happens? For the same reason devtmpfs_mount() accepts a path instead of just assuming "/dev". > +       if (strncmp(dev_path, "/dev/", 5) != 0) > +               return -1; Same here. Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/