Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757943AbZFJP5T (ORCPT ); Wed, 10 Jun 2009 11:57:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760322AbZFJP5G (ORCPT ); Wed, 10 Jun 2009 11:57:06 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:55875 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760448AbZFJP5F (ORCPT ); Wed, 10 Jun 2009 11:57:05 -0400 Date: Wed, 10 Jun 2009 16:58:22 +0100 From: Alan Cox To: Dirk Eibach Cc: linux-kernel@vger.kernel.org, jirislaby@gmail.com, Dirk Eibach Subject: Re: [PATCH] char: prevent opening unavailable ports in moxa.c Message-ID: <20090610165822.5b947273@lxorguk.ukuu.org.uk> In-Reply-To: <1244530656-32766-1-git-send-email-eibach@gdsys.de> References: <1244530656-32766-1-git-send-email-eibach@gdsys.de> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 21 On Tue, 9 Jun 2009 08:57:36 +0200 Dirk Eibach wrote: > In moxa.c there are 32 minor numbers reserved for each device. The > number of ports actually available per device is stored in > moxa_board_conf->numPorts. This number is not considered in moxa_open(). > Opening a port that is not available results in a kernel oops. > This patch adds a test to moxa_open() that prevents opening unavailable > ports. > > Signed-off-by: Dirk Eibach Applied - thanks Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/