Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761766AbZFKCDW (ORCPT ); Wed, 10 Jun 2009 22:03:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757820AbZFKCDM (ORCPT ); Wed, 10 Jun 2009 22:03:12 -0400 Received: from bilbo.ozlabs.org ([203.10.76.25]:60409 "EHLO bilbo.ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757215AbZFKCDL (ORCPT ); Wed, 10 Jun 2009 22:03:11 -0400 Subject: Re: [PATCH] Re:[BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] From: Michael Ellerman Reply-To: michael@ellerman.id.au To: subrata@linux.vnet.ibm.com Cc: Stephen Rothwell , netdev@vger.kernel.org, Li Yang , Sachin P Sant , Linuxppc-dev , Linux-Next , Linux-Kernel , Balbir Singh In-Reply-To: <1244685364.6494.14.camel@subratamodak.linux.ibm.com> References: <20090610174323.28045.70169.sendpatchset@subratamodak.linux.ibm.com> <20090611110523.1fd56a41.sfr@canb.auug.org.au> <1244685364.6494.14.camel@subratamodak.linux.ibm.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Gs/KyC+TrNDFjdC2ZtWn" Date: Thu, 11 Jun 2009 12:03:11 +1000 Message-Id: <1244685791.4674.12.camel@concordia> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1678 Lines: 53 --=-Gs/KyC+TrNDFjdC2ZtWn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2009-06-11 at 07:26 +0530, Subrata Modak wrote: > On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote: > > Hi Subrata, > >=20 > > On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak wrote: > > > > > > /* Find the TBI PHY. If it's not there, we don't support SGMII */ > > > - ph =3D of_get_property(np, "tbi-handle", NULL); > > > + ph =3D (phandle *)of_get_property(np, "tbi-handle", NULL); > >=20 > > You don't need this cast because of_get_property() returns "void *". >=20 > Stephen, >=20 > True. But without this gcc complains: >=20 > CC [M] drivers/net/ucc_geth.o > drivers/net/ucc_geth.c: In function =E2=80=98ucc_geth_probe=E2=80=99: > drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers from= pointer target type ^^^^^^^^^^^ And what does that warning actually mean? Your cast actually introduces a bug. cheers --=-Gs/KyC+TrNDFjdC2ZtWn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkowZd8ACgkQdSjSd0sB4dLk5gCcC/h3ugX0KI34JeU9onHHPv7t iL8AnA6s3XJ6wOJGrHrwg+LQavqZWNw/ =5Ygr -----END PGP SIGNATURE----- --=-Gs/KyC+TrNDFjdC2ZtWn-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/