Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761732AbZFKCe6 (ORCPT ); Wed, 10 Jun 2009 22:34:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752906AbZFKCeu (ORCPT ); Wed, 10 Jun 2009 22:34:50 -0400 Received: from ozlabs.org ([203.10.76.45]:59637 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbZFKCeu (ORCPT ); Wed, 10 Jun 2009 22:34:50 -0400 From: Rusty Russell To: "Langsdorf, Mark" Subject: Re: [PATCH 4/6] x86/cpufreq: use cpumask_copy instead of = Date: Thu, 11 Jun 2009 12:04:47 +0930 User-Agent: KMail/1.11.2 (Linux/2.6.28-11-generic; KDE/4.2.2; i686; ; ) Cc: "Linus Torvalds" , "Yinghai Lu" , "Avi Kivity" , "Ingo Molnar" , "Andrew Morton" , "Thomas Gleixner" , "H. Peter Anvin" , linux-kernel@vger.kernel.org, "Dave Jones" , cpufreq@vger.kernel.org References: <4A2835D8.6040903@kernel.org> <200906101552.17397.rusty@rustcorp.com.au> <6453C3CB8E2B3646B0D020C1126132730362099D@sausexmb4.amd.com> In-Reply-To: <6453C3CB8E2B3646B0D020C1126132730362099D@sausexmb4.amd.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906111204.48441.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 633 Lines: 18 On Thu, 11 Jun 2009 05:12:16 am Langsdorf, Mark wrote: > > powernow_k8_target is problematic: it grabs a mutex. cpufreq > > people, is this called often? > > Yes. It's the function that makes a frequency change > happen, so 5+ times per second per core isn't > unreasonable. Right, so we need to revisit this. I'll leave it for the moment and put it on my TODO list. Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/