Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755337AbZFKGOd (ORCPT ); Thu, 11 Jun 2009 02:14:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752590AbZFKGOY (ORCPT ); Thu, 11 Jun 2009 02:14:24 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:52695 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752574AbZFKGOY (ORCPT ); Thu, 11 Jun 2009 02:14:24 -0400 Message-ID: <4A30A05C.4060703@cn.fujitsu.com> Date: Thu, 11 Jun 2009 14:12:44 +0800 From: Gui Jianfeng User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Vivek Goyal CC: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, dm-devel@redhat.com, jens.axboe@oracle.com, nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com, mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it, ryov@valinux.co.jp, fernando@oss.ntt.co.jp, s-uchida@ap.jp.nec.com, taka@valinux.co.jp, jmoyer@redhat.com, dhaval@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com, righi.andrea@gmail.com, m-ikeda@ds.jp.nec.com, jbaron@redhat.com, agk@redhat.com, snitzer@redhat.com, akpm@linux-foundation.org, peterz@infradead.org Subject: Re: [PATCH 04/19] io-controller: Modify cfq to make use of flat elevator fair queuing References: <1244513342-11758-1-git-send-email-vgoyal@redhat.com> <1244513342-11758-5-git-send-email-vgoyal@redhat.com> In-Reply-To: <1244513342-11758-5-git-send-email-vgoyal@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 55 Vivek Goyal wrote: > This patch changes cfq to use fair queuing code from elevator layer. > last_end_request in cic is of no use anymore. Get rid of it. Signed-off-by: Gui Jianfeng --- block/cfq-iosched.c | 4 ---- include/linux/iocontext.h | 1 - 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 5871568..705e7ba 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c @@ -1170,7 +1170,6 @@ cfq_alloc_io_context(struct cfq_data *cfqd, gfp_t gfp_mask) cic = kmem_cache_alloc_node(cfq_ioc_pool, gfp_mask | __GFP_ZERO, q->node); if (cic) { - cic->last_end_request = jiffies; INIT_LIST_HEAD(&cic->queue_list); INIT_HLIST_NODE(&cic->cic_list); cic->dtor = cfq_free_io_context; @@ -1794,9 +1793,6 @@ static void cfq_completed_request(struct request_queue *q, struct request *rq) if (!cfq_class_idle(cfqq)) cfqd->last_end_request = now; - - if (sync) - RQ_CIC(rq)->last_end_request = now; } /* diff --git a/include/linux/iocontext.h b/include/linux/iocontext.h index 1fe9d78..9c4587b 100644 --- a/include/linux/iocontext.h +++ b/include/linux/iocontext.h @@ -39,7 +39,6 @@ struct cfq_io_context { struct io_context *ioc; - unsigned long last_end_request; sector_t last_request_pos; unsigned int seek_samples; -- 1.5.4.rc3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/