Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756398AbZFKMwo (ORCPT ); Thu, 11 Jun 2009 08:52:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751807AbZFKMwg (ORCPT ); Thu, 11 Jun 2009 08:52:36 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:44220 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbZFKMwg (ORCPT ); Thu, 11 Jun 2009 08:52:36 -0400 Date: Thu, 11 Jun 2009 08:52:27 -0400 From: Christoph Hellwig To: Ingo Molnar Cc: Steven Rostedt , Christoph Hellwig , Frederic Weisbecker , LKML , Andrew Morton , Minchan Kim , Mel Gorman , Rik van Riel , Pekka Enberg , Peter Zijlstra , Theodore Tso , Mathieu Desnoyers , Lai Jiangshan , Zhaolei , KOSAKI Motohiro , Jason Baron , Jiaying Zhang Subject: Re: [PATCH][GIT PULL] tracing: do not translate event helper macros in print format Message-ID: <20090611125227.GA14220@infradead.org> References: <20090609014534.790466803@goodmis.org> <20090609014746.481457542@goodmis.org> <20090609192159.GD6057@nowhere> <20090610094819.GA25527@infradead.org> <20090610101124.GA25042@elte.hu> <20090610171648.GD31096@elte.hu> <20090610204801.GB8147@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090610204801.GB8147@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 26 On Wed, Jun 10, 2009 at 10:48:02PM +0200, Ingo Molnar wrote: > > This looks like it changed more than it really did, I only moved > > the one macro above another and added a few lines: > > > > +#undef __print_symbolic > > +#undef __get_dynamic_array > > +#undef __get_str > > tracing: do not translate event helper macros in print format > > > > By moving the macro that creates the print format code above the > > defining of the event macro helpers (__get_str, __print_symbolic, > > and __get_dynamic_array), we get a little cleaner print format. __print_flags should also be added, shouldn't it? Maybe also le/be*_to_cpu/cpu_to_le/be*? and major/minor? We should also document those helpers that need special treatment somewhere? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/