Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759249AbZFKND2 (ORCPT ); Thu, 11 Jun 2009 09:03:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751238AbZFKNDU (ORCPT ); Thu, 11 Jun 2009 09:03:20 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:55414 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbZFKNDU (ORCPT ); Thu, 11 Jun 2009 09:03:20 -0400 Date: Thu, 11 Jun 2009 09:03:18 -0400 From: Christoph Hellwig To: Theodore Tso , Steven Rostedt , Fr?d?ric Weisbecker , Ingo Molnar , linux-kernel@vger.kernel.org, Andrew Morton , Minchan Kim , Mel Gorman , Christoph Hellwig , Rik van Riel , Pekka Enberg , Peter Zijlstra , Mathieu Desnoyers , Lai Jiangshan , Zhaolei , KOSAKI Motohiro , Jason Baron , Jiaying Zhang , Tom Zanussi , Xiao Guangrong Subject: Re: [PATCH 00/11] [GIT PULL] more updates for the tag format Message-ID: <20090611130318.GB14220@infradead.org> References: <20090610054206.510574695@goodmis.org> <20090610092644.GA20889@elte.hu> <20090610130127.GA6647@mit.edu> <20090610160303.GA10240@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090610160303.GA10240@mit.edu> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 20 On Wed, Jun 10, 2009 at 12:03:03PM -0400, Theodore Tso wrote: > Yes, another approach for handling this case would be to take my > "jbd2_dev_to_name" function and support it as a first-class tagged > type; after all, I'm sure ext4 won't be the only place that would like > to take a dev_t and print the device name. So this could certainly be > fixed by adding some kind of "" sort of tagged name. We should absolutely agree on one way to represent block device for tracers. At this point xfs, gfs2 and the block tracer all use major/minor. I agree that having a name would be nicer for text output, but I really want to keep the dev_t for the binary output. We should also make sure we agree on a field name so that filtering will work the same for all block-related tracers (especially important if we want to trace something from the filesystem down to the block layer). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/