Date: Thu, 11 Jun 2009 09:04:07 -0400 (EDT)
From: Steven Rostedt <rostedt@goodmis.org>
To: Christoph Hellwig <hch@infradead.org>
cc: Ingo Molnar <mingo@elte.hu>, Frederic Weisbecker <fweisbec@gmail.com>,
       LKML <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       Minchan Kim <minchan.kim@gmail.com>, Mel Gorman <mel@csn.ul.ie>,
       Rik van Riel <riel@redhat.com>, Pekka Enberg <penberg@cs.helsinki.fi>,
       Peter Zijlstra <peterz@infradead.org>, Theodore Tso <tytso@mit.edu>,
       Mathieu Desnoyers <compudj@krystal.dyndns.org>,
       Lai Jiangshan <laijs@cn.fujitsu.com>, Zhaolei <zhaolei@cn.fujitsu.com>,
       KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
       Jason Baron <jbaron@redhat.com>, Jiaying Zhang <jiayingz@google.com>
Subject: Re: [PATCH][GIT PULL] tracing: do not translate event helper macros
 in print format
In-Reply-To: <20090611125227.GA14220@infradead.org>
Message-ID: <alpine.DEB.2.00.0906110902530.30552@gandalf.stny.rr.com>
References: <20090609014534.790466803@goodmis.org> <20090609014746.481457542@goodmis.org> <20090609192159.GD6057@nowhere> <20090610094819.GA25527@infradead.org> <20090610101124.GA25042@elte.hu> <alpine.DEB.2.00.0906100812370.30552@gandalf.stny.rr.com>
 <20090610171648.GD31096@elte.hu> <alpine.DEB.2.00.0906101353200.30552@gandalf.stny.rr.com> <alpine.DEB.2.00.0906101436340.30552@gandalf.stny.rr.com> <20090610204801.GB8147@elte.hu> <20090611125227.GA14220@infradead.org>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1246
Lines: 39


On Thu, 11 Jun 2009, Christoph Hellwig wrote:

> On Wed, Jun 10, 2009 at 10:48:02PM +0200, Ingo Molnar wrote:
> > > This looks like it changed more than it really did, I only moved 
> > > the one macro above another and added a few lines:
> > > 
> > >  +#undef __print_symbolic
> > >  +#undef __get_dynamic_array
> > >  +#undef __get_str
> 
> > >     tracing: do not translate event helper macros in print format
> > >     
> > >     By moving the macro that creates the print format code above the
> > >     defining of the event macro helpers (__get_str, __print_symbolic,
> > >     and __get_dynamic_array), we get a little cleaner print format.
> 
> __print_flags should also be added, shouldn't it?

Darn, I knew I forgot one :-/

> 
> Maybe also le/be*_to_cpu/cpu_to_le/be*? and major/minor?

We can only include macros that we define later. Otherwise we undefine 
them for when we need them.

-- Steve

> 
> We should also document those helpers that need special treatment
> somewhere?
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/