Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763281AbZFKNWZ (ORCPT ); Thu, 11 Jun 2009 09:22:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762941AbZFKNWD (ORCPT ); Thu, 11 Jun 2009 09:22:03 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:48541 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763256AbZFKNWB (ORCPT ); Thu, 11 Jun 2009 09:22:01 -0400 Date: Thu, 11 Jun 2009 16:22:02 +0300 (EEST) From: Pekka J Enberg To: Alexander Beregalov cc: linux-next , Linux Kernel Mailing List , Mel Gorman Subject: Re: next-20090611: SLUB: Unable to allocate memory on node -1 In-Reply-To: Message-ID: References: <84144f020906110612t3102efdev39e77b6429013176@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1467 Lines: 47 On Thu, 11 Jun 2009, Alexander Beregalov wrote: > > There should be a stack trace here printed out by the page allocator. > > Can you post that too? > > I do not see it: Aah, it's a false positive. The following patch ought to fix it. Pekka >From d3b9557331bf4b73b80632b15eed062bf30683ac Mon Sep 17 00:00:00 2001 From: Pekka Enberg Date: Thu, 11 Jun 2009 16:18:09 +0300 Subject: [PATCH] SLUB: Don't print out OOM warning for __GFP_NOFAIL We must check for __GFP_NOFAIL like the page allocator does; otherwise we end up with false positives. While at it, add the printk_ratelimit() check in SLUB as well. Cc: Alexander Beregalov Signed-off-by: Pekka Enberg --- mm/slub.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index c0d5341..4d7cabf 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1631,7 +1631,8 @@ new_slab: c->page = new; goto load_freelist; } - slab_out_of_memory(s, gfpflags, node); + if (!(gfpflags & __GFP_NOWARN) && printk_ratelimit()) + slab_out_of_memory(s, gfpflags, node); return NULL; debug: if (!alloc_debug_processing(s, c->page, object, addr)) -- 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/