Date: Thu, 11 Jun 2009 11:27:48 -0700
From: Jesse Barnes <jesse.barnes@intel.com>
To: Alex Chiang <achiang@hp.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: eliminate redundant pci_stop_dev() call from
 pci_destroy_dev()
Message-ID: <20090611112748.0601e347@jbarnes-g45>
In-Reply-To: <20090519010222.12679.74898.stgit@bob.kio>
References: <20090519010222.12679.74898.stgit@bob.kio>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1178
Lines: 38

On Mon, 18 May 2009 19:02:38 -0600
Alex Chiang <achiang@hp.com> wrote:

> We always call pci_stop_bus_device before calling pci_destroy_dev.
> 
> Since pci_stop_bus_device calls pci_stop_dev, there is no need
> for pci_destroy_dev to repeat the call.
> 
> Signed-off-by: Alex Chiang <achiang@hp.com>
> ---
> 
>  drivers/pci/remove.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
> index 86503c1..176615e 100644
> --- a/drivers/pci/remove.c
> +++ b/drivers/pci/remove.c
> @@ -32,8 +32,6 @@ static void pci_stop_dev(struct pci_dev *dev)
>  
>  static void pci_destroy_dev(struct pci_dev *dev)
>  {
> -	pci_stop_dev(dev);
> -
>  	/* Remove the device from the device lists, and prevent any
> further
>  	 * list accesses from this device */
>  	down_write(&pci_bus_sem);

Applied to linux-next, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/