Date: Thu, 11 Jun 2009 11:42:04 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
cc: Tejun Heo <tj@kernel.org>, Steven Rostedt <srostedt@redhat.com>,
       Li Zefan <lizf@cn.fujitsu.com>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] first block round for 2.6.31
In-Reply-To: <20090611182657.GY11363@kernel.dk>
Message-ID: <alpine.LFD.2.01.0906111134180.3573@localhost.localdomain>
References: <20090611111339.GQ11363@kernel.dk> <alpine.LFD.2.01.0906111105021.3573@localhost.localdomain> <20090611182657.GY11363@kernel.dk>
User-Agent: Alpine 2.01 (LFD 1184 2008-12-16)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1107
Lines: 35


On Thu, 11 Jun 2009, Jens Axboe wrote:
> 
> > Btw, Jens: in your tree, you've committed Tejun's changes without adding 
> > your own sign-off. Not good!
> 
> That's for the patches that I pulled from his git tree. It should list
> him as committer too.

NO!

It sounds like you have done a _major_ no-no, which is to pull from his 
tree, and then rebase it. 

DO NOT DO THAT! NOT EVER!

If you pull from somebody elses tree, you can no longer touch the commit. 
It absolutely has to stay the same. Otherwise we see this kind of insane 
duplication. 

You're doing something seriously wrong here. I wrote a long rant about 
what the rules were last release cycle, but now I can't find it. 
Basically, if you're not the committer, you really must never EVER touch 
it. 

[ Anybody with enough google-fu to find my rant, so I don't have to 
  re-rant? ]

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/