Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758849AbZFLIJb (ORCPT ); Fri, 12 Jun 2009 04:09:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754508AbZFLIJS (ORCPT ); Fri, 12 Jun 2009 04:09:18 -0400 Received: from mx2.redhat.com ([66.187.237.31]:53946 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754019AbZFLIJQ (ORCPT ); Fri, 12 Jun 2009 04:09:16 -0400 Date: Fri, 12 Jun 2009 10:02:12 +0200 From: Stanislaw Gruszka To: Richard Kennedy Cc: Thomas Gleixner , "linux-kernel@vger.kernel.org" , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Andrew Morton Subject: Re: [PATCH 2/2] posix-cpu-timers: remove tasklist_lock where we can Message-ID: <20090612100212.06f56a79@dhcp-lab-109.englab.brq.redhat.com> In-Reply-To: <4A320848.6000701@rsk.demon.co.uk> References: <20090612084927.11673956@dhcp-lab-109.englab.brq.redhat.com> <4A320848.6000701@rsk.demon.co.uk> Organization: RedHat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 504 Lines: 17 On Fri, 12 Jun 2009 08:48:24 +0100 Richard Kennedy wrote: > > - read_unlock(&tasklist_lock); > > + rcu_read_lock(); > > > Did you really intend to replace an unlock with a lock? Intention was quite different. Thanks Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/