Date: Fri, 12 Jun 2009 04:37:32 -0400 (EDT)
From: Justin Piszcz <jpiszcz@lucidpixels.com>
To: Felix Blyakher <felixb@sgi.com>
cc: Eric Sandeen <sandeen@sandeen.net>, linux-kernel@vger.kernel.org,
       xfs@oss.sgi.com
Subject: Re: Kernel 2.6.30: Memory/XFS leak, OOM killer kills many
 processes
In-Reply-To: <96F5FBF8-17B6-4AA9-BAB4-377AF596692C@sgi.com>
Message-ID: <alpine.DEB.2.00.0906120420080.26259@p34.internal.lan>
References: <alpine.DEB.2.00.0906111158470.2563@p34.internal.lan> <alpine.DEB.2.00.0906111255280.6809@p34.internal.lan> <4A313F84.20900@sandeen.net> <96F5FBF8-17B6-4AA9-BAB4-377AF596692C@sgi.com>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1037
Lines: 47


On Thu, 11 Jun 2009, Felix Blyakher wrote:

>
> On Jun 11, 2009, at 12:31 PM, Eric Sandeen wrote:
>
>> Justin Piszcz wrote:
>>> 
>>> On Thu, 11 Jun 2009, Justin Piszcz wrote:
>>> 
> The following should fix it:
>
> diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c
> index 4b0f6ef..7928b99 100644
> --- a/fs/xfs/xfs_bmap.c
> +++ b/fs/xfs/xfs_bmap.c
> @@ -6086,6 +6086,7 @@ xfs_getbmap(
>                      break;
>      }
>
> +       kmem_free(out);
>      return error;
> }
>
>
> Felix

Just FYI if anyone tries to run the patch it will not work:

# patch -p1 < ../xfs.patch 
patching file fs/xfs/xfs_bmap.c
patch: **** malformed patch at line 11: }

So just goto line ~6086 and add the kmem_free(out); above the return 
error.

Status:
This patch fixes the problem, thanks!

Justin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/