DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=wjrFsvjA3ERGaKJ/cvsIzDsvq/E22q9yKe8rCJgiXrkkDtWPyZ2xMjYoLb/L5iRJLT
         6E192f58PtBFKl3XrNuXHcYiGNpjRckibTlsUuyLay5spioTGTixCbIzaHiQDPqeyOOI
         ARmFHMWKrhi9a2XwR1FXnTjvsqMaXSecKUas8=
MIME-Version: 1.0
In-Reply-To: <5D8775BD-9973-4DE8-B442-91FB15F86ACC@kernel.crashing.org>
References: <1242117363-14949-1-git-send-email-leoli@freescale.com>
	 <90AED712-28A1-4800-978C-125A887D0DA7@kernel.crashing.org>
	 <3A45394FD742FA419B760BB8D398F9ED483CCD@zch01exm26.fsl.freescale.net>
	 <5D8775BD-9973-4DE8-B442-91FB15F86ACC@kernel.crashing.org>
Date: Fri, 12 Jun 2009 21:27:58 +0800
Message-ID: <2a27d3730906120627l112030b3wa11ea5aa3fcb1087@mail.gmail.com>
Subject: Re: [PATCH 1/6] rapidio: add common mapping APIs for RapidIO memory 
	access
From: Li Yang <leoli@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: akpm@linux-foundation.org, davem@davemloft.net,
       mporter@kernel.crashing.org, linux-kernel@vger.kernel.org,
       linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
       Zhang Wei <zw@zh-kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1926
Lines: 44

On Thu, Jun 11, 2009 at 9:32 PM, Kumar Gala<galak@kernel.crashing.org> wrote:
>
> On Jun 11, 2009, at 4:47 AM, Li Yang-R58472 wrote:
>
>>> On May 12, 2009, at 3:35 AM, Li Yang wrote:
>>>
>>>> Add the mapping functions used to support direct IO memory access of
>>>> rapidIO.
>>>>
>>>> Signed-off-by: Zhang Wei <zw@zh-kernel.org>
>>>> Signed-off-by: Li Yang <leoli@freescale.com>
>>>
>>> Use inbnd/outbnd instead of inb/outb which make one think of
>>> byte level io accessors.
>>>
>>> As I look at this I don't think this is the correct API.  I
>>> think we should be using the DMA mapping API to hide these
>>> details.  The concept of mapping like this seems to be more a
>>> function of FSL's Address translation/mapping unit (ATMU) than
>>> anything specific to the RIO bus standard.
>>
>> This is a separate RIO block level ATMU.  Although it looks like the
>> system level ATMU, system ATMU doesn't have the knowledge of rapidIO
>> target device ID.  The mapping need to be dynamic, as it's easy to have
>> more RIO devices than the outbound windows.
>
> I understand that.  What I'm saying is the RIO block level ATMU is a
> Freescale specific detail and not part of any standard RIO bus programming
> model.  We have mapping APIs that we can connect to for this via the DMA API
> layer.

Ok, I see your point now. Do you mean dma_map_*() for DMA API layer?
But in my understanding the current dma_map_*() APIs are preparing
local memory for device to access which is similar to the inbound
case.  Is it suitable to also use them for mapping device's space for
CPU access?  Can you give an example of using this API for Address
Translation and Mapping purpose?

- Leo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/