From: Roland Dreier <rdreier@cisco.com>
To: Jesse Barnes <jesse.barnes@intel.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>, Matthew Wilcox <matthew@wil.cx>,
       Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
       "general\@lists.openfabrics.org" <general@lists.openfabrics.org>,
       "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: mthca double free irqs
References: <86802c440906111945n2a42dc94mf08bd2b1a252842f@mail.gmail.com>
	<adafxe51pz9.fsf@cisco.com> <20090612085053.0fbe9731@jbarnes-g45>
Date: Fri, 12 Jun 2009 09:25:36 -0700
In-Reply-To: <20090612085053.0fbe9731@jbarnes-g45> (Jesse Barnes's message of
	"Fri, 12 Jun 2009 08:50:53 -0700")
Message-ID: <ada4oul1ksf.fsf@cisco.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 821
Lines: 18


 > My linux-next branch has a change to the return value from the MSI-X
 > allocation function: pci_enable_msix now returns the number of
 > available entries rather than -EINVAL if the allocation failed.  Would
 > that cause problems in the mthca driver?

I don't think so in this case ... the driver is getting past enabling
MSI-X and actually testing the interrupt before it fails.  I'll audit
the code just to make sure we handle that case though.  But I thought
pci_enable_msix() always returned the number of entries actually
available if the allocation failed?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/