Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765632AbZFLRox (ORCPT ); Fri, 12 Jun 2009 13:44:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757521AbZFLRop (ORCPT ); Fri, 12 Jun 2009 13:44:45 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:49452 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755312AbZFLRoo (ORCPT ); Fri, 12 Jun 2009 13:44:44 -0400 Message-ID: <4A329322.7030403@oracle.com> Date: Fri, 12 Jun 2009 10:40:50 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Mike Frysinger CC: Ingo Molnar , Peter Zijlstra , Paul Mackerras , linux-kernel@vger.kernel.org, samr Subject: Re: [PATCH] perf_counters: start documenting HAVE_PERF_COUNTERS requirements References: <1244827063-24046-1-git-send-email-vapier@gentoo.org> <20090612173031.GA11233@elte.hu> <8bd0f97a0906121032p12710878h14c5013fbec58b91@mail.gmail.com> <20090612173647.GC22015@elte.hu> <8bd0f97a0906121040m5222cd5et77ecc1bd5edb6b89@mail.gmail.com> In-Reply-To: <8bd0f97a0906121040m5222cd5et77ecc1bd5edb6b89@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: abhmt007.oracle.com [141.146.116.16] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4A3293F9.020B:SCFSTAT5015188,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2100 Lines: 56 Mike Frysinger wrote: > On Fri, Jun 12, 2009 at 13:36, Ingo Molnar wrote: >> * Mike Frysinger wrote: >>> On Fri, Jun 12, 2009 at 13:30, Ingo Molnar wrote: >>>> * Mike Frysinger wrote: >>>>> Help out arch porters who want to support perf counters by listing some >>>>> basic requirements. >>>>> >>>>> Signed-off-by: Mike Frysinger >>>>> --- >>>>> i imagine more details would be good, but this is a starting point and >>>>> better than nothing >>>>> >>>>> init/Kconfig | 2 ++ >>>>> tools/perf/design.txt | 15 +++++++++++++++ >>>>> 2 files changed, 17 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/init/Kconfig b/init/Kconfig >>>>> index c649657..20f85b1 100644 >>>>> --- a/init/Kconfig >>>>> +++ b/init/Kconfig >>>>> @@ -936,6 +936,8 @@ config AIO >>>>> >>>>> config HAVE_PERF_COUNTERS >>>>> bool >>>>> + help >>>>> + See end of tools/perf/design.txt >>>>> >>>>> menu "Performance Counters" >>>> Applied, thanks Mike! I have made a small change: i changed it from >>>> help text into a regular comment. We usually use help texts for >>>> interactive Kconfig options - but this is not one. >>> yes, but i like the help text because when i use the kconfig >>> search option, it shows up. otherwise doing a search for >>> HAVE_PERF_COUNTERS shows nothing useful. >> When i did this modification i tried that in 'make menuconfig' and >> the help didnt show up. Is it only available in certain kconfig >> methods? There is no prompt string for it, so it's invisible in menuconfig. xconfig has View options that can show it. > hrm, you're right. not sure what i was thinking of. sounds like an > enhancement request though for kconfig. Could be. Cc: Sam added. -- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/