Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765220AbZFLVrr (ORCPT ); Fri, 12 Jun 2009 17:47:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934268AbZFLVr3 (ORCPT ); Fri, 12 Jun 2009 17:47:29 -0400 Received: from gate.crashing.org ([63.228.1.57]:42093 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934273AbZFLVr2 (ORCPT ); Fri, 12 Jun 2009 17:47:28 -0400 Subject: Re: [GIT PULL v2] Early SLAB fixes for 2.6.31 From: Benjamin Herrenschmidt To: Christoph Lameter Cc: Pekka J Enberg , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com, lizf@cn.fujitsu.com, mingo@elte.hu, npiggin@suse.de, yinghai@kernel.org In-Reply-To: References: Content-Type: text/plain Date: Sat, 13 Jun 2009 07:46:03 +1000 Message-Id: <1244843163.23936.2.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 25 > Adds code to hot code path. A single mask which should be mostly in the noise... > The allocators mask flags passed to the page allocator through > GFP_RECLAIM_MASK|GFP_CONSTRAINT_MASK. This is done outside of the critical > code paths. > > The might_sleep issues may be fixed by adding another check to > __might_sleep(). That is not enough because slab and slub explicitely re-enable interrupts when __GFP_WAIT is set, which is the problem we need to solve in the first place, so we need to do the masking there. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/