Date: Sat, 13 Jun 2009 08:42:53 +0200
From: Ingo Molnar <mingo@elte.hu>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: David Miller <davem@davemloft.net>, randy.dunlap@oracle.com,
       linux-kernel@vger.kernel.org, mchan@broadcom.com,
       torvalds@linux-foundation.org,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: -git tree build failure in drivers/net/cnic.c: undefined
	reference to `ip6_route_output'
Message-ID: <20090613064253.GB14034@elte.hu>
References: <20090612184343.GA11900@elte.hu> <4A32A1E4.8080708@oracle.com> <20090612.165108.110857018.davem@davemloft.net> <1244851393.26552.1.camel@mulgrave.site>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1244851393.26552.1.camel@mulgrave.site>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1792
Lines: 44


* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> On Fri, 2009-06-12 at 16:51 -0700, David Miller wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > Date: Fri, 12 Jun 2009 11:43:48 -0700
> > 
> > > Ingo Molnar wrote:
> > >> today's -git fails to build with ipv6 disabled (x86):
> > >> 
> > >>   drivers/built-in.o: In function `cnic_get_v6_route':
> > >>   cnic.c:(.text+0x104c42): undefined reference to `ip6_route_output'
> > >> 
> > >> introduced by this new driver:
> > >> 
> > >>   a463696: [SCSI] cnic: Add new Broadcom CNIC driver.
> > > 
> > > I just posted a patch for this to netdev and it was acked by its maintainer.
> > > Patch is below.
> > 
> > I was hoping the scsi folks, or Linus directly, would pick this up.
> 
> I can, but my first tree's just gone ... the next one won't be 
> going until nearer the merge window.

The thing is, this driver has been submitted 4 days ago, merged by 
you 3 days ago and sent upstream two days ago. It has two build 
breakages so far, the first one of which triggered on a pretty 
common config too.

If you have time for such speedy integration but then dont have time 
to test on common configs and dont have time to follow up on and 
fix/merge the (pretty much inevitable) upstream breakages you 
introduce and get the fixes to Linus, sending prompt fixes next-day 
preferably, out of your usual schedule, it would be a better 
solution for you to submit new drivers to the staging tree i think - 
which does have the capacity to fix and merge such stuff.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/