In-Reply-To: <200906091952.47842.arnd@arndb.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-arch@vger.kernel.org,
       linux-arch-owner@vger.kernel.org, linux-kernel@vger.kernel.org,
       torvalds@linux-foundation.org
MIME-Version: 1.0
Subject: Re: [PATCH 22/27] score: create kernel files signal.c sys_score.c time.c
Message-ID: <OF3AABEDAD.28BB4A96-ON482575D4.0024BA2D-482575D4.002550FA@sunplusct.com>
From: liqin.chen@sunplusct.com
Date: Sat, 13 Jun 2009 14:43:08 +0800
Content-Type: text/plain; charset="GB2312"
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1596
Lines: 51

linux-arch-owner@vger.kernel.org д?? 2009-06-10 01:52:47:

> On Tuesday 09 June 2009, liqin.chen@sunplusct.com wrote:
> > +asmlinkage long sys_mmap(unsigned long addr, size_t len,
> > +                       unsigned long prot, unsigned long flags,
> > +                       unsigned long fd, off_t offset)
> > +{
> > +       int err = -EINVAL;
> > +
> > +       if (offset & ~PAGE_MASK) {
> > +               printk(KERN_INFO "no pagemask in mmap\r\n");
> > +               goto out;
> > +       }
> > +
> > +       err = sys_mmap2(addr, len, prot, flags, fd, offset >> 
PAGE_SHIFT);
> > +out:
> > +       return err;
> > +}
> 
> A 32 bit kernel should only need sys_mmap2, not sys_mmap, because it is
> trivial to convert in user space.
> 
> > +
> > +asmlinkage long score_vfork(struct pt_regs *regs)
> > +{
> > +       return do_fork(CLONE_VFORK | CLONE_VM | SIGCHLD, 
regs->regs[0],
> > +                                               regs, 0, NULL, NULL);
> > +}
> > +
> > +/*
> > + * Fork a new task - this creates a new program thread.
> > + * This is called indirectly via a small wrapper
> > + */
> > +asmlinkage int
> > +score_fork(struct pt_regs *regs)
> > +{
> > +       return do_fork(SIGCHLD, regs->regs[0], regs, 0, NULL, NULL);
> > +}
> 
> Similarly, you should not need vfork and fork any more, because they can
> be handled in user space through clone().
> 

OK, I remove these from my code.

Best Regards
liqin
--
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?