In-Reply-To: <200906092019.06812.arnd@arndb.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-arch@vger.kernel.org,
       linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
MIME-Version: 1.0
Subject: Re: [PATCH 00/27] score arch files for linux
Message-ID: <OFFDE0B66A.CCDF7360-ON482575D4.0024FAC6-482575D4.00260499@sunplusct.com>
From: liqin.chen@sunplusct.com
Date: Sat, 13 Jun 2009 14:50:47 +0800
Content-Type: text/plain; charset="GB2312"
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1800
Lines: 47

Hi Arnd,

Arnd Bergmann <arnd@arndb.de> д?? 2009-06-10 02:19:06:

> On Tuesday 09 June 2009, liqin.chen@sunplusct.com wrote:
> > Hi Arnd, Andrew Morton and linus,
> > 
> > According to your comment on score arch code, 
> > we update score code base on asm-generic#next repository.
> > use arch microblaze and blackfin as reference.
> 
> Ok, just finished looking over the patches and I am generally
> very happy about their quality, it usually takes much longer
> for a submission of this size to get into a mergeable shape.
> 
> The only thing that I think needs to be fixed before a
> 2.6.31 release is my comment about unistd.h still containing
> the __ARCH_WANT_SYSCALL_* #defines. I consider that my fault
> because I did not make it clear enough what those are meant
> for in asm-generic/unistd.h.
> 
> One more general thought: I noticed that you split the header
> files by alphabetical ordering. While there is no good way to
> split a set of interdependent files, a logical grouping
> (e.g. ABI, memory management, device, cpu) would be nice.
> 
> Everything else I found are only polite suggestions of what
> can still be improved, not issues that I think need to
> be addressed immediately. I especially love how the work
> that Remis and I put into the generic header files starts
> paying off, because it makes reviewing an architecture so
> much simpler.
> 
> Please add my 'Reviewed-by: Arnd Bergmann <arnd@arndb.de>'
> to your patches.
> 

Based on your comments, I use asm-generic/current.h, hardirq.h,
unaligned.h etc instead of files under arch/include/asm folder.
It could work in score code.

Best Regards
Liqin
--


????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?