Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761255AbZFMLK1 (ORCPT ); Sat, 13 Jun 2009 07:10:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751278AbZFMLKO (ORCPT ); Sat, 13 Jun 2009 07:10:14 -0400 Received: from 8bytes.org ([88.198.83.132]:38243 "EHLO 8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbZFMLKN (ORCPT ); Sat, 13 Jun 2009 07:10:13 -0400 Date: Sat, 13 Jun 2009 13:10:14 +0200 From: Joerg Roedel To: Torsten Kaiser Cc: Joerg Roedel , FUJITA Tomonori , Linus Torvalds , mingo@elte.hu, lethal@linux-sh.org, hancockrwd@gmail.com, jens.axboe@oracle.com, bharrosh@panasas.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] dma-debug: disable DMA_API_DEBUG for now Message-ID: <20090613111014.GA18638@8bytes.org> References: <20090605173232N.fujita.tomonori@lab.ntt.co.jp> <20090605104132.GE24836@amd.com> <64bb37e0906101341j341f5179o9abfa888a6b96fc3@mail.gmail.com> <20090611081032.GN5139@amd.com> <64bb37e0906111038h1a5b9f17oec6c6368d2fbd36d@mail.gmail.com> <20090612141346.GY5139@amd.com> <64bb37e0906120751u14cac347hfa2356372e1e0a6a@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64bb37e0906120751u14cac347hfa2356372e1e0a6a@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1495 Lines: 33 On Fri, Jun 12, 2009 at 04:51:01PM +0200, Torsten Kaiser wrote: > On Fri, Jun 12, 2009 at 4:13 PM, Joerg Roedel wrote: > > On Thu, Jun 11, 2009 at 07:38:47PM +0200, Torsten Kaiser wrote: > >> DMA-API: device driver tries to free DM > >> A memory it has not allocated [device address=0x000000011e4c3000] > >> [size=4096 bytes] > > > > Hmm, looking again over the code I've seen that the ref > > dma_debug_entries are not alway filled with all necessary information > > for best-fit. Can you please try if you still get false warnings when > > you apply the two patches attached instead of the one I sent yesterday? > > Hmm... There isn't a get_nr_mapped_entries() in 2.6.30. > Are these patches again the current linus tree? Indeed. These patches are against tip/core/iommu but should also apply against current linus/master too. > For unfilled information I wanted to complain that for non-sg mapping > sg_call_ents never gets filled. But as dma_entry_alloc() does a > memset() to clean the entrys it should not matter. > And what about dma_debug_entry.paddr? Should this also be compared? paddr shouldn't matter. We also can't compare against it because it is not a parameter we get in the unmap path (not always). Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/