Date: Sat, 13 Jun 2009 13:55:38 +0100
From: Darren Salt <linux@youmustbejoking.demon.co.uk>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>, linux-kernel@vger.kernel.org,
       acpi4asus-user@lists.sourceforge.net,
       Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH 2.6.29] eeepc-laptop: report brightness control events via  the input layer
Message-ID: <507032D758%linux@youmustbejoking.demon.co.uk>
In-Reply-To: <71cd59b00906130306w319c0fc2i376bb03323845b80@mail.gmail.com>
References: <504BBE2828%linux@youmustbejoking.demon.co.uk> 
 <20090404041813.GA30746@srcf.ucam.org> 
 <9b2b86520906080824i134ee546v33990176b0d3e618@mail.gmail.com> 
 <71cd59b00906130155u2757ade3t3378685846b80410@mail.gmail.com> 
 <4A337251.7010705@tuffmail.co.uk> 
 <71cd59b00906130306w319c0fc2i376bb03323845b80@mail.gmail.com>
Mail-Followup-To: Corentin Chary <corentin.chary@gmail.com>, Alan Jenkins 
 <alan-jenkins@tuffmail.co.uk>, linux-kernel@vger.kernel.org, 
 acpi4asus-user@lists.sourceforge.net, Matthew Garrett <mjg59@srcf.ucam.org>, 
 Darren Salt <linux@youmustbejoking.demon.co.uk>
User-Agent: Messenger-Pro/2.58.3.3080 (Qt/4.5.1) (Linux-x86_64)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1688
Lines: 39

I demand that Corentin Chary may or may not have written...

> On Sat, Jun 13, 2009 at 11:33 AM, Alan Jenkins<alan-jenkins@tuffmail.co.uk>
> wrote:
[snip]
>> The firmware still changes the brightness immediately.  It seems
>> that when g-p-m gets delayed, it responds _wrongly_. It doesn't realize
>> that the firmware already changed the brightness, so it changes the
>> brightness again.

Should it be changing the brightness at all? I ask because every laptop which
I've used will change the brightness without userspace being involved.
(Although it's possible that g-p-m might get brightness-change events from
some source other than that which is used to report the laptop's own
brightness controls...)

[snip]
> Version: 2.24.2-2ubuntu8
> Ok I can reproduce [the brightness being changed inappropriately from
> userspace].

> I want to check if we can't fix g-p-m before reverting the patch. If
> there is no way to fix it, I'll revert.

I don't see that it can ever be reliable in the face of the brightness having
already been changed without userspace involvement short of being able to
tell it to report only on some/all events from some input devices.

-- 
| Darren Salt      | linux at youmustbejoking | nr. Ashington, | Doon
| Debian GNU/Linux | or ds    ,demon,co,uk    | Northumberland | Army
| + Generate power using sun, wind, water, nuclear.      FORGET COAL AND OIL.

A foolish consistency is the hobgoblin of little minds.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/