Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757014AbZFNKqw (ORCPT ); Sun, 14 Jun 2009 06:46:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755968AbZFNKqn (ORCPT ); Sun, 14 Jun 2009 06:46:43 -0400 Received: from mail-yx0-f171.google.com ([209.85.210.171]:47185 "EHLO mail-yx0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755474AbZFNKqn (ORCPT ); Sun, 14 Jun 2009 06:46:43 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=DTUzn8dscoRE7lYvUhi9K7JyHqv3SzdDBNcbA2c8yg5QQHNwQ+5kG/SYOYq+6ggV2Z 9bxBBX7cjYg7jYmpAF9E80oPpI0IGWr+V2O8f/DzaInWIbxSztkgWWqAAC0bEWUVCJTU dwLeSU+Zd3+v8vvFZ+ARgzxTye+M9Gakj1qbA= MIME-Version: 1.0 In-Reply-To: <20090614104212.GA5977@localhost> References: <1244872920-13511-1-git-send-email-vapier@gentoo.org> <20090614100110.GA19875@localhost> <20090614104212.GA5977@localhost> From: Mike Frysinger Date: Sun, 14 Jun 2009 06:46:24 -0400 Message-ID: <8bd0f97a0906140346t6b19f00aq29cfd4c554682f07@mail.gmail.com> Subject: Re: [PATCH] ramfs: ignore tmpfs options when we emulate it To: Wu Fengguang Cc: Hugh Dickins , Mike Frysinger , Andrew Morton , Matt Mackall , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 20 On Sun, Jun 14, 2009 at 06:42, Wu Fengguang wrote: > On Sun, Jun 14, 2009 at 06:01:10PM +0800, Wu Fengguang wrote: > Sorry I take back the previous patch. It makes sense to not break > existing user space tools, but a warning message looks OK to remind > people of possibly unexpected behavior. > > default: > printk(KERN_ERR "ramfs: bad mount option: %s\n", p); > - return -EINVAL; > + break; hmm, if the warning was wrapped in #ifdef CONFIG_SHMEM, i'd be ok with this. otherwise we end up with warnings that can (should) be ignored when tmpfs is being emulated with ramfs. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/