Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758804AbZFNOvZ (ORCPT ); Sun, 14 Jun 2009 10:51:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755169AbZFNOvP (ORCPT ); Sun, 14 Jun 2009 10:51:15 -0400 Received: from mms2.broadcom.com ([216.31.210.18]:3237 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbZFNOvO convert rfc822-to-8bit (ORCPT ); Sun, 14 Jun 2009 10:51:14 -0400 X-Server-Uuid: D3C04415-6FA8-4F2C-93C1-920E106A2031 From: "Michael Chan" To: "'James Bottomley'" cc: "Linus Torvalds" , "Ingo Molnar" , "Randy Dunlap" , "linux-kernel@vger.kernel.org" , "David S. Miller" , linux-scsi Date: Sun, 14 Jun 2009 07:51:07 -0700 Subject: Re: -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function '__symbol_get' Thread-Topic: -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function '__symbol_get' Thread-Index: Acns+pAjgpEEIrtpTUSqyNajtMClzgACzGkw Message-ID: In-Reply-To: <1244988911.4096.23.camel@mulgrave.site> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-WSS-ID: 662BD1D638G6135635-01-01 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 32 James Bottomley wrote: > On Sat, 2009-06-13 at 19:18 -0700, Michael Chan wrote: > > > > This will require some additional infra-structure. We can look into > > this when we support the 10G driver. Thanks. > > So if you're going to redo it for the 10G driver, and without the 10G > driver there really seems no need to have a call by > reflection in there, > why not simply do a direct call until the 10G driver is added? This > will save everyone potential hassle from what is a highly unusual > interface. > There's an additional usage issue if we switch to a direct call. The cnic driver will now have a permanent reference on the bnx2 driver after it is loaded. Networking users will be unable to unload the bnx2 driver once the cnic driver is loaded. This may not be a serious issue, but one of the goals of the design is to have minmal impact on networking users. Since kernel 2.6, users have been able to unload networking drivers at any time. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/