Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762534AbZFNTYS (ORCPT ); Sun, 14 Jun 2009 15:24:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759722AbZFNTYJ (ORCPT ); Sun, 14 Jun 2009 15:24:09 -0400 Received: from www.tglx.de ([62.245.132.106]:60346 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753219AbZFNTYI (ORCPT ); Sun, 14 Jun 2009 15:24:08 -0400 Date: Sun, 14 Jun 2009 21:23:59 +0200 From: "Hans J. Koch" To: Wolfram Sang Cc: "Hans J. Koch" , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org, Magnus Damm , Greg KH Subject: Re: [PATCH 2/2] uio: add an of_genirq driver Message-ID: <20090614192359.GG3639@local> References: <1244765062-14144-1-git-send-email-w.sang@pengutronix.de> <1244765062-14144-3-git-send-email-w.sang@pengutronix.de> <20090614122136.GD3639@local> <20090614171406.GA1010@pengutronix.de> <20090614183357.GE3639@local> <20090614190533.GA7387@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090614190533.GA7387@pengutronix.de> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1936 Lines: 63 On Sun, Jun 14, 2009 at 09:05:33PM +0200, Wolfram Sang wrote: > > > Anyway, 0 is a valid IRQ number, so it cannot be used as "no irq". > > May I point you to this thread? > > http://lkml.org/lkml/2005/11/21/221 Linus is just plain wrong in this 4 year old mail. > > (The issue comes up once in a while as some archs still use NO_IRQ, some with > 0 some with -1) > > > > if (uioinfo->irq == NO_IRQ) > > > uioinfo->irq = UIO_IRQ_NONE; > > > > Sorry for my ignorance, but what is NO_IRQ? If I do a > > > > grep -r NO_IRQ include/ > > > > I get nothing. > > Try a 'cd arch' before that :) no such luck in arch/x86/ ... > > > Well, you claim it's a false positive. So far, you did not get any responses, > > AFAICS. I tend to agree with you, but I'd like to avoid patches that don't > > pass checkpatch.pl, whatever the reason. Either the false positive gets > > confirmed and fixed, or you should fix your patch. > > Well, I assume that issues regarding checkpatch do not have the highest > priority (especially while the merge-window is open), which is understandable. > Fixing this bug (I take any bets that this is one ;)) might not be so trivial, > as modifying $Attributes can easily have lots of side-effects. > > Now, all this does not matter much, as the objections Grant raised are valid > and there might be a totally different outcome to bind devices to UIO. But at > least, we have some code to discuss... OK, I'm looking forward to your next version. Thanks, Hans > > Regards, > > Wolfram > > -- > Pengutronix e.K. | Wolfram Sang | > Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/