From: Arnd Bergmann <arnd@arndb.de>
To: Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH 4/4] asm-generic: uaccess: fix access_ok() prototype
Date: Sun, 14 Jun 2009 22:17:50 +0200
User-Agent: KMail/1.11.90 (Linux/2.6.30-8-generic; KDE/4.2.85; x86_64; ; )
Cc: linux-kernel@vger.kernel.org
References: <1244959204-11269-1-git-send-email-vapier@gentoo.org> <1244959204-11269-4-git-send-email-vapier@gentoo.org>
In-Reply-To: <1244959204-11269-4-git-send-email-vapier@gentoo.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <200906142217.50997.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 993
Lines: 23

On Sunday 14 June 2009, Mike Frysinger wrote:
> @@ -37,14 +37,14 @@ static inline void set_fs(mm_segment_t fs)
>  #define VERIFY_READ    0
>  #define VERIFY_WRITE   1
>  
> -#define access_ok(type, addr, size) __access_ok((unsigned long)(addr),(size))
> +#define access_ok(type, addr, size) __access_ok((addr), (size))
>  
>  /*
>   * The architecture should really override this if possible, at least

Upon actually testing this change, it turns out that this causes more
trouble because of having to pass down pointers that may have 'const'
or 'volatile' modifiers. I'm sure there is a way to do this correctly,
but most architectures seem to cope well with 'unsigned long' here,
and your patch 3/4 solves the original problem nicely.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/