Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763765AbZFNUYx (ORCPT ); Sun, 14 Jun 2009 16:24:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754627AbZFNUYp (ORCPT ); Sun, 14 Jun 2009 16:24:45 -0400 Received: from pfepa.post.tele.dk ([195.41.46.235]:32809 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754105AbZFNUYp (ORCPT ); Sun, 14 Jun 2009 16:24:45 -0400 Date: Sun, 14 Jun 2009 22:27:04 +0200 From: Sam Ravnborg To: Nico Schottelius , Christian Kujau , LKML , Andrew Morton Subject: Re: [PATCH] scripts/setlocalversion on readonly source Message-ID: <20090614202704.GA3050@uranus.ravnborg.org> References: <20090611153332.d168e58e.akpm@linux-foundation.org> <20090612043922.GA13001@uranus.ravnborg.org> <20090612075952.GA22436@ikn.schottelius.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090612075952.GA22436@ikn.schottelius.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 32 > > > Do not update index on read only media. > Idea published by Christian Kujau . > > diff --git a/scripts/setlocalversion b/scripts/setlocalversion > index 0079047..46989b8 100755 > --- a/scripts/setlocalversion > +++ b/scripts/setlocalversion > @@ -39,8 +39,10 @@ if head=`git rev-parse --verify --short HEAD 2>/dev/null`; then > printf -- '-svn%s' "`git svn find-rev $head`" > fi > > - # Are there uncommitted changes? > - git update-index --refresh --unmerged > /dev/null > + # Update index only on r/w media > + [ -w . ] && git update-index --refresh --unmerged > /dev/null > + > + # Check for uncommitted changes > if git diff-index --name-only HEAD | grep -v "^scripts/package" \ > | read dummy; then > printf '%s' -dirty Please sign-off future patches. I applied this with no signoff - but this is an exception. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/