Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763471AbZFNVbn (ORCPT ); Sun, 14 Jun 2009 17:31:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756532AbZFNVbf (ORCPT ); Sun, 14 Jun 2009 17:31:35 -0400 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:52594 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756328AbZFNVbe (ORCPT ); Sun, 14 Jun 2009 17:31:34 -0400 Date: Mon, 15 Jun 2009 06:30:49 +0900 From: Paul Mundt To: Linus Walleij Cc: Tim Bird , linux-arm-kernel , linux kernel , Russell King , Steven Rostedt , Ingo Molnar , Tony Lindgren Subject: Re: [PATCH] ftrace,arm: add notrace to ARM sched_clock routines - resend Message-ID: <20090614213049.GA15366@linux-sh.org> Mail-Followup-To: Paul Mundt , Linus Walleij , Tim Bird , linux-arm-kernel , linux kernel , Russell King , Steven Rostedt , Ingo Molnar , Tony Lindgren References: <4A32D1AF.7060107@am.sony.com> <63386a3d0906141051v50cc441fj27f0132fa5c77b80@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63386a3d0906141051v50cc441fj27f0132fa5c77b80@mail.gmail.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1386 Lines: 32 On Sun, Jun 14, 2009 at 07:51:04PM +0200, Linus Walleij wrote: > 2009/6/13 Tim Bird : > > > Add notrace attribute to sched_clock, to avoid > > recursion with ftrace function tracing. > > > > Signed-off-by: Tim Bird > > --- > > arch/arm/mach-mmp/time.c | 2 +- > > arch/arm/mach-pxa/time.c | 2 +- > > arch/arm/mach-realview/core.c | 2 +- > > arch/arm/mach-sa1100/generic.c | 2 +- > > arch/arm/mach-versatile/core.c | 2 +- > > arch/arm/plat-omap/common.c | 4 ++-- > > 6 files changed, 7 insertions(+), 7 deletions(-) > > And now that Paul Mundt is making it possible to use the default > sched_clock() with the generic clocksource and the OMAP hack > will likely go away, should the default implementation in > kernel/sched_clock.c also be tagged as > unsigned long long notrace __attribute__((weak)) sched_clock(void) > or something? > > Should it be tagged notrace even if it's the old jiffybased one even? > Thanks for pointing that out. Yes, the new generic version will need the notrace attribute as well, I will include this in the next iteration. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/