Date: Mon, 15 Jun 2009 10:50:23 +0100
From: Ben Dooks <ben-linux@fluff.org>
To: Alek Du <alek.du@intel.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and
	gpio_alt_func features to GPIOLIB
Message-ID: <20090615095023.GA19873@fluff.org.uk>
References: <20090615171502.2a981bf5@dxy.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090615171502.2a981bf5@dxy.sh.intel.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1317
Lines: 36

On Mon, Jun 15, 2009 at 05:15:02PM +0800, Alek Du wrote:
> >From 7a76916ccea4a376a260ea67fbc79ac4d958757f Mon Sep 17 00:00:00 2001
> From: Alek Du <alek.du@intel.com>
> Date: Fri, 8 May 2009 09:46:49 +0800
> Subject: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB
> 
> Add some more functions to GPIOLIB, they are:
> * gpio_detect is to set GPIO interrupt triggering method (edge, level, high,
>   low, etc.)
> * gpio_debounce is to set GPIO trigger HW debounce value if GPIO hw supports.
> * gpio_alt_func is to set pin as alternative function or GPIO.

gpio_alt_func is feature creep, I don't really belive this is the
best place to put it as it will be difficult to actually make this
generic for all gpio platforms.

> +enum gpio_trigger_t {
> +	DETECT_LEVEL_LOW = -2,
> +	DETECT_EDGE_FALLING = -1,
> +	DETECT_DISABLE = 0,
> +	DETECT_EDGE_RISING = 1,
> +	DETECT_LEVEL_HIGH = 2,
> +	DETECT_EDGE_BOTH = 3,
> +};

wny not reuse the IRQ trigger types?

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/