Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761976AbZFOPuV (ORCPT ); Mon, 15 Jun 2009 11:50:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754336AbZFOPuJ (ORCPT ); Mon, 15 Jun 2009 11:50:09 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:55814 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751814AbZFOPuI (ORCPT ); Mon, 15 Jun 2009 11:50:08 -0400 Date: Mon, 15 Jun 2009 16:51:26 +0100 From: Alan Cox To: Vegard Nossum Cc: Pekka Enberg , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty_ldisc: propagate errors from tty_ldisc_release Message-ID: <20090615165126.1ecdff09@lxorguk.ukuu.org.uk> In-Reply-To: <20090615153925.GA27696@damson.getinternet.no> References: <20090615153925.GA27696@damson.getinternet.no> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 653 Lines: 17 > Subject: [PATCH] tty_ldisc: propagate errors from tty_ldisc_release > > This is probably better than just ignoring the errors. tty_ldisc_halt doesn't return an error as such - it just reports whether the work could be cancelled. Nor can we exit on error paths in those situations. Basically one or two cases need to know if we cancelled the work queue or not (so they can restart it). So NAK the patch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/