Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761709AbZFOPv0 (ORCPT ); Mon, 15 Jun 2009 11:51:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756405AbZFOPvS (ORCPT ); Mon, 15 Jun 2009 11:51:18 -0400 Received: from smtp3.ultrahosting.com ([74.213.175.254]:50115 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754336AbZFOPvR (ORCPT ); Mon, 15 Jun 2009 11:51:17 -0400 Date: Mon, 15 Jun 2009 11:51:11 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Pekka Enberg cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com, lizf@cn.fujitsu.com, mingo@elte.hu, npiggin@suse.de, yinghai@kernel.org, benh@kernel.crashing.org Subject: Re: [GIT PULL v2] Early SLAB fixes for 2.6.31 In-Reply-To: <84144f020906150827k1b8c0ce4q5ed4d140f7ca869@mail.gmail.com> Message-ID: References: <1245077891.23207.48.camel@penberg-laptop> <1245078661.23207.50.camel@penberg-laptop> <84144f020906150827k1b8c0ce4q5ed4d140f7ca869@mail.gmail.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 22 On Mon, 15 Jun 2009, Pekka Enberg wrote: > > OK, I can clean this up, no problem. > > Actually, there's a slight complication here. If I push gfp mask to > __might_sleep(), lockdep_trace_alloc() and so on, the mask is > effective _everywhere_ even outside of slab. Yes, it makes sense if we > push the masking right down to the page allocator but I wonder if > that's something we want to do at this point? __might_sleep just should not trigger right? The mask does not need to be passed. __might_sleep may be called uselessly during bootup if __GFP_WAIT is set. But it should not trigger any output. Look at the initial statements of __might_sleep: They are already prepared to simply return in the early boot case. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/