Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763325AbZFOQao (ORCPT ); Mon, 15 Jun 2009 12:30:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763204AbZFOQab (ORCPT ); Mon, 15 Jun 2009 12:30:31 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:59439 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762914AbZFOQaa (ORCPT ); Mon, 15 Jun 2009 12:30:30 -0400 Date: Mon, 15 Jun 2009 09:29:54 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Liam Girdwood cc: Andrew Morton , linux-kernel Subject: Re: [GIT PULL] voltage regulator updates for 2.6.31-rc1 In-Reply-To: <1245065061.21421.90.camel@vega.slimlogic.co.uk> Message-ID: References: <1245065061.21421.90.camel@vega.slimlogic.co.uk> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 33 On Mon, 15 Jun 2009, Liam Girdwood wrote: > > drivers/regulator/lp3971.c | 562 ++++++++++++++++++++++++++ > include/linux/regulator/lp3971.h | 51 +++ So I really don't like this. Why the heck would "lp3971.h" be under "include/linux"? That makes no sense what-so-ever. Why isn't it just drivers/regulator/lp3971.c drivers/regulator/lp3971.h instead? There is never any reason for anything but the lp3971 driver to include its own header file, they should _not_ be split up to be in two different places. In fact, why do we have a "include/linux/regulator/" at all? Does anybody else ever care? I doubt it. Anyway, I pulled it, but I think this needs to be fixed. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/