Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765015AbZFOSZf (ORCPT ); Mon, 15 Jun 2009 14:25:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762247AbZFOSZ2 (ORCPT ); Mon, 15 Jun 2009 14:25:28 -0400 Received: from smtp-out.google.com ([216.239.45.13]:34903 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756272AbZFOSZ1 convert rfc822-to-8bit (ORCPT ); Mon, 15 Jun 2009 14:25:27 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:content-transfer-encoding:x-system-of-record; b=ftXxFiyXs023bhSfEzcdVUHJsSOGhWwtT4sxWBojQLxBYs/xwb8bwVfG1ReWGy8hy AembPrKjw71gEF+lF1WbA== MIME-Version: 1.0 In-Reply-To: <20090615132248.GB14555@elf.ucw.cz> References: <1245033557-10968-1-git-send-email-swetland@google.com> <1245033557-10968-2-git-send-email-swetland@google.com> <1245033557-10968-3-git-send-email-swetland@google.com> <1245033557-10968-4-git-send-email-swetland@google.com> <20090615132248.GB14555@elf.ucw.cz> Date: Mon, 15 Jun 2009 11:25:26 -0700 Message-ID: Subject: Re: [PATCH 3/3] [ARM] msm: add minimal board file for HTC Dream device From: Brian Swetland To: Pavel Machek Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1039 Lines: 32 On Mon, Jun 15, 2009 at 6:22 AM, Pavel Machek wrote: >> >> +config MACH_TROUT >> +     default y >> +     bool "HTC Dream (aka trout)" >> +     help >> +       Support for the HTC Dream, T-Mobile G1, Android ADP1 devices. >> + >>  endif > > ...but I guess renaming config option makes sense too.. This is trickier, as MACH_* is autogenerated based on the machine name, which also becomes the machine name userspace sees. >> +static void __init trout_init_irq(void) >> +{ >> +     msm_init_irq(); >> +} > > ...and most occurences of trout, here, too... (I'm not sure if some > are required for compatibility with existing userland?) Yup -- userland depends on the name. We could rename the functions in the board file though as that wouldn't break anything. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/