Date: Mon, 15 Jun 2009 20:28:50 +0200
From: Pavel Machek <pavel@ucw.cz>
To: Brian Swetland <swetland@google.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] [ARM] msm: add minimal board file for HTC Dream
	device
Message-ID: <20090615182850.GA10490@elf.ucw.cz>
References: <1245033557-10968-1-git-send-email-swetland@google.com> <1245033557-10968-2-git-send-email-swetland@google.com> <1245033557-10968-3-git-send-email-swetland@google.com> <1245033557-10968-4-git-send-email-swetland@google.com> <20090615132248.GB14555@elf.ucw.cz> <a55d774e0906151125h36ee7c36yb9ecf5fb3fb8e41b@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a55d774e0906151125h36ee7c36yb9ecf5fb3fb8e41b@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1709
Lines: 47

On Mon 2009-06-15 11:25:26, Brian Swetland wrote:
> On Mon, Jun 15, 2009 at 6:22 AM, Pavel Machek<pavel@ucw.cz> wrote:
> >>
> >> +config MACH_TROUT
> >> + ? ? default y
> >> + ? ? bool "HTC Dream (aka trout)"
> >> + ? ? help
> >> + ? ? ? Support for the HTC Dream, T-Mobile G1, Android ADP1 devices.
> >> +
> >> ?endif
> >
> > ...but I guess renaming config option makes sense too..
> 
> This is trickier, as MACH_* is autogenerated based on the machine
> name, which also becomes the machine name userspace sees.

Ok.

> >> +static void __init trout_init_irq(void)
> >> +{
> >> + ? ? msm_init_irq();
> >> +}
> >
> > ...and most occurences of trout, here, too... (I'm not sure if some
> > are required for compatibility with existing userland?)
> 
> Yup -- userland depends on the name.  We could rename the functions in
> the board file though as that wouldn't break anything.

Yes, please.

(Now... I'm trying to figure out how leds are set up. It seems that
there are two classes -- leds-gpio, which is backlights, and 4colored
led. I'd like to use 4colored led for debugging... Unfortunately
drivers/leds/leds-cpld.c is quite "interesting" (and really abuses
interface at least with "blink" file). Is there easy way to turn some
light manually, best something that works early and can be used for
debugging?)
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/