Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935565AbZFOVdn (ORCPT ); Mon, 15 Jun 2009 17:33:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758092AbZFOVdh (ORCPT ); Mon, 15 Jun 2009 17:33:37 -0400 Received: from gate.crashing.org ([63.228.1.57]:44167 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757700AbZFOVdg (ORCPT ); Mon, 15 Jun 2009 17:33:36 -0400 Subject: Re: [GIT PULL v2] Early SLAB fixes for 2.6.31 From: Benjamin Herrenschmidt To: Nick Piggin Cc: Pekka Enberg , Heiko Carstens , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, cl@linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com, lizf@cn.fujitsu.com, mingo@elte.hu, yinghai@kernel.org In-Reply-To: <20090615112355.GB6012@wotan.suse.de> References: <20090615081831.GA5411@osiris.boeblingen.de.ibm.com> <84144f020906150210w7fa29042xc12efb4a087e3d26@mail.gmail.com> <20090615094148.GC1314@wotan.suse.de> <1245059476.12400.7.camel@pasglop> <1245059859.23207.16.camel@penberg-laptop> <20090615102737.GA20461@wotan.suse.de> <1245062727.12400.23.camel@pasglop> <20090615112355.GB6012@wotan.suse.de> Content-Type: text/plain Date: Tue, 16 Jun 2009 07:31:38 +1000 Message-Id: <1245101498.12400.37.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1191 Lines: 31 On Mon, 2009-06-15 at 13:23 +0200, Nick Piggin wrote: > > I think the main problem isn't necessarily init code per se, but the > > pile of -common- code that can be called both at init time and > later. > > Just seems bogus argument. Everwhere else that does this (ie. > allocations that are called from multiple allocation contexts) > passes correct gfp flags down. So you say we should create new variants of all these APIs that take gfp flags as arguments just because they might be called early during boot : - All the vmalloc interfaces (__get_vm_area() and it's 5 or 6 variants) - Allocation of PCI host bridges data structures in the powerpc code - Allocation of interrupt controller domains in the powerpc code - Page table allocations (oops ... can't change that arch specific, would have to be a generic change) - ioremap (which call both __get_vm_area() and page table allocs) - ... Are you just insane ? :-) Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/