Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935598AbZFOVmn (ORCPT ); Mon, 15 Jun 2009 17:42:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754772AbZFOVmi (ORCPT ); Mon, 15 Jun 2009 17:42:38 -0400 Received: from e24smtp05.br.ibm.com ([32.104.18.26]:35076 "EHLO e24smtp05.br.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752667AbZFOVmh (ORCPT ); Mon, 15 Jun 2009 17:42:37 -0400 Message-ID: <4A36C04B.6070204@linux.vnet.ibm.com> Date: Mon, 15 Jun 2009 18:42:35 -0300 From: Rajiv Andrade User-Agent: Thunderbird 2.0.0.21 (X11/20090614) MIME-Version: 1.0 To: Eric Paris CC: =?UTF-8?B?ImRkcyAo4piVKSI=?= , seiji.munetoh@gmail.com, tpmdd-devel@lists.sourceforge.net, Mimi Zohar , linux-kernel , Shahbaz Khan Subject: Re: [tpmdd-devel] TPM drivers support and Linux Integrity Module for 2.6.30 References: <20cbb9450906112259m176153c9ucfa7a4d14642949f@mail.gmail.com> <1244817141.3401.7.camel@dyn9002018117.watson.ibm.com> <4A3474BD.4000804@linux.vnet.ibm.com> <1245007238.10712.5.camel@blackbox> <1245068894.3247.22.camel@dhcp231-142.rdu.redhat.com> <4A367093.6010206@linux.vnet.ibm.com> In-Reply-To: <4A367093.6010206@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1023 Lines: 27 > 2- Forget manufacturer_id and base the decision on the PNP_ID as david > suggested. I previously considered it but since it would end up in > modifying tpm_tis_init() prototype (struct device * to struct pnp_dev *) > and then wouldn't work when loading as a module with force option on, so > I moved to the manufacturer_id approach. > > I'll get back to #2 meanwhile and post the patch, seems not hard to > accomplish though.. > Yes, it wasn't hard, at all, just get the id with to_pnp_dev(dev)->id. However, the chip is buggy, there's no reason to make a compliant upstream code modify its behavior just due an 'exception' for a not compliant hardware. No need to worry about it too though, the workaround is available as I pointed earlier (Seiji's)... Thanks, Rajiv -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/