Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935802AbZFOWQ6 (ORCPT ); Mon, 15 Jun 2009 18:16:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752237AbZFOWQt (ORCPT ); Mon, 15 Jun 2009 18:16:49 -0400 Received: from mail-ew0-f210.google.com ([209.85.219.210]:32875 "EHLO mail-ew0-f210.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022AbZFOWQs convert rfc822-to-8bit (ORCPT ); Mon, 15 Jun 2009 18:16:48 -0400 MIME-Version: 1.0 In-Reply-To: <200906152335.48926.mroth@nessie.de> References: <200906152335.48926.mroth@nessie.de> Date: Mon, 15 Jun 2009 15:16:49 -0700 X-Google-Sender-Auth: d03a34d099f97fa6 Message-ID: Subject: Re: [PATCH 5/6] Unified AVR32/AT91 MCI Driver Support for a VCC Pin From: Rob Emanuele To: Michael Roth Cc: linux-arm-kernel@lists.arm.linux.org.uk, Haavard Skinnemoen , Andrew Victor , Nicolas Ferre , linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 26 That would be fine with me. On Mon, Jun 15, 2009 at 2:35 PM, Michael Roth wrote: > >> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c >> index 1c1a4b3..a639b93 100644 >> --- a/drivers/mmc/host/atmel-mci.c >> +++ b/drivers/mmc/host/atmel-mci.c >> @@ -214,6 +214,8 @@ struct atmel_mci_slot { >> >> ? ? ? int ? ? ? ? ? ? ? ? ? ? detect_pin; >> ? ? ? int ? ? ? ? ? ? ? ? ? ? wp_pin; >> + ? ? int ? ? ? ? ? ? ? ? ? ? vcc_pin; >> + ? ? bool ? ? ? ? ? ? ? ? ? ?vcc_pin_act_low; > > Maybe, just 'vcc_active_low' is more clear? > > Most other kernel code use 'active_low' or 'xyz_active_low' as far as I can > see. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/