DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=d54YTQPVfQyCpQia9yQNcP4aFfarpEXzwTgcCwXfW0dwsgSbsQK7AI+qYn5Es9dP2SaPl++gO+Ywpa5p0gMKDOTISRCxd3DuQquAV0S1Gy9v042rx8F7DetIpla+dHlwHU1hgOEBtysN1sti+sjlWi91QM0R1yJqOhlhbixPQBY=  ;
From: David Brownell <david-b@pacbell.net>
To: Baruch Siach <baruch@tkos.co.il>
Subject: Re: [PATCH v5] gpio: driver for PrimeCell PL061 GPIO controller
Date: Mon, 15 Jun 2009 16:29:11 -0700
User-Agent: KMail/1.9.10
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
       linux-arm-kernel@lists.arm.linux.org.uk,
       "Russell King - ARM Linux" <linux@arm.linux.org.uk>
References: <1244708976-22122-1-git-send-email-baruch@tkos.co.il>
In-Reply-To: <1244708976-22122-1-git-send-email-baruch@tkos.co.il>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200906151629.11350.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1241
Lines: 36

On Thursday 11 June 2009, Baruch Siach wrote:
> +static unsigned int pl061_irq_startup(unsigned irq)
> +{
> +???????if (gpio_request(irq_to_gpio(irq), "IRQ") == 0)
> +???????????????pr_warning("%s: warning: GPIO%d has not been requested\n",
> +???????????????????????????????__func__, irq_to_gpio(irq));

No, that's the responsibility of whoever is setting this up.

Normally, platform setup code would request the GPIO since it's
being dedicated to some task on the board ... and then pass the
gpio_to_irq() value as a device resource, or maybe the GPIO itself
(if the driver had to deal with GPIOs per se).

Also, irq_to_gpio() can be problematic in some systems; avoid it.


> +
> +???????pl061_irq_enable(irq);
> +
> +???????return 0;
> +}

Remove that gpio_request(), and the irq_to_gpio(), and you get:

Acked-by: David Brownell <dbrownell@users.sourceforge.net>

The driver is a trifle unusual in having only eight bits per bank,
but that's just hardware.  Software looks clean, thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/