DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=G83WtMAISn4zUglju4C71Tez3OPZlnUzq9CWimMEPkbKhQJC3gJmxc9IqcZoeXiV47C0vrdcaclpgz4RoOzKLaUiWfJ0FXjK+U6VX3CiZ7WFo8ChOm2VL8+s+iipHg/TZ9JaSX0XVeplGPF1lqq7LQznChnhpPgNhkxZdLqo3xg=  ;
From: David Brownell <david-b@pacbell.net>
To: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
Subject: Re: [PATCH v3] gpio: driver for PrimeCell PL061 GPIO controller
Date: Mon, 15 Jun 2009 16:38:04 -0700
User-Agent: KMail/1.9.10
Cc: Baruch Siach <baruch@tkos.co.il>, linux-kernel@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>
References: <1243975690-12073-1-git-send-email-baruch@tkos.co.il> <20090604092835.GJ29926@n2100.arm.linux.org.uk>
In-Reply-To: <20090604092835.GJ29926@n2100.arm.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200906151638.05008.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 995
Lines: 26

On Thursday 04 June 2009, Russell King - ARM Linux wrote:
> > +static unsigned int pl061_irq_startup(unsigned irq)
> > +{
> > +?????int ret;
> > +
> > +?????ret = gpio_request(irq_to_gpio(irq), "IRQ");
> > +?????if (ret < 0) {
> > +?????????????pr_warning("%s: warning: gpio_request(%d) returned %d\n",
> > +?????????????????????????????__func__, irq_to_gpio(irq), ret);
> > +?????????????return 0;
> > +?????}
> > +
> > +?????gpio_direction_input(irq_to_gpio(irq));
> 
> I thought that it was not expected that claiming an interrupt would claim
> a GPIO automatically - in other words, it's the responsibility of the
> driver or platform itself to claim GPIOs for interrupts and ensure that
> they're properly configured.

You're right about that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/