Date: Tue, 16 Jun 2009 09:28:48 +0800
From: Alek Du <alek.du@intel.com>
To: Ben Dooks <ben-linux@fluff.org>
CC: Florian Fainelli <florian@openwrt.org>, Ben Dooks <ben-linux@fluff.org>,
       Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and
 gpio_alt_func features to GPIOLIB
Message-ID: <20090616092848.7bb60f21@dxy.sh.intel.com>
In-Reply-To: <20090615130906.GA14476@trinity.fluff.org>
References: <20090615171502.2a981bf5@dxy.sh.intel.com>
	<20090615125146.GC19873@fluff.org.uk>
	<200906151504.51934.florian@openwrt.org>
	<20090615130906.GA14476@trinity.fluff.org>
Organization: Intel Corp.
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1105
Lines: 26

On Mon, 15 Jun 2009 21:09:06 +0800
Ben Dooks <ben-linux@fluff.org> wrote:

> > 
> > I would expect your architecture IRQ handler to have a set_type callback for 
> > the GPIO lines capables of generating an interrupt. See how we have beeing 
> > doing it for rb532 for instance: 
> > http://www.linux-mips.org/git?p=linux-queue.git;a=blob;f=arch/mips/rb532/irq.c;h=f07882029a90d3d155c17b462812c2936229458c;hb=HEAD#l173
> 
> Yes, or if the GPIO driver is exporting interrupts, the relevant handler
> for that chip should have the .set_type method defined.
> 

In the .set_type method, you finally will call the GPIO driver's function to set interrupt trigger mode, right?
Current GPIOLIB do not provide such an interface. Current driver always exports a separate function to do that --
that's not good.
My patch provide a general API to do that.


Thanks,
Alek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/