Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759833AbZFPSVK (ORCPT ); Tue, 16 Jun 2009 14:21:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753165AbZFPSU6 (ORCPT ); Tue, 16 Jun 2009 14:20:58 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:46605 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751596AbZFPSU5 (ORCPT ); Tue, 16 Jun 2009 14:20:57 -0400 Date: Tue, 16 Jun 2009 11:20:48 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Ryan Hope cc: Dave Airlie , Greg KH , Dave Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.sf.net Subject: Re: [git pull] drm - fixes + radeon KMS (part 2) In-Reply-To: <48f7fe350906160853m41f43fe5i892a4057b5eae319@mail.gmail.com> Message-ID: References: <20090615022235.GA12905@kroah.com> <21d7e9970906141943s8dd6e27sd4308413601d65e3@mail.gmail.com> <48f7fe350906160853m41f43fe5i892a4057b5eae319@mail.gmail.com> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 582 Lines: 26 On Tue, 16 Jun 2009, Ryan Hope wrote: > > +#ifdef MODULE > module_init(radeon_init); > +#else > +late_initcall(radeon_init); > +#endif You should never need something like that. Just do late_initcall(radeon_init); and if it's a module (which doesn't have "early" vs "late" etc), it will just be a normal module_init. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/