Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760389AbZFPUWr (ORCPT ); Tue, 16 Jun 2009 16:22:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755481AbZFPUWi (ORCPT ); Tue, 16 Jun 2009 16:22:38 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:33952 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753438AbZFPUWh (ORCPT ); Tue, 16 Jun 2009 16:22:37 -0400 Date: Tue, 16 Jun 2009 13:21:27 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Oleg Nesterov cc: David Howells , Eugene Teo , James Morris , Roland McGrath , solar@openwall.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] shift current_cred() from __f_setown() to f_modown() In-Reply-To: <20090616200746.GA28663@redhat.com> Message-ID: References: <4A36532E.3050006@redhat.com> <20090615174544.GA10467@redhat.com> <4A36E555.80206@redhat.com> <20090616183829.GA10027@redhat.com> <20090616200746.GA28663@redhat.com> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 19 On Tue, 16 Jun 2009, Oleg Nesterov wrote: > > Shift current_cred() from __f_setown() to f_modown(). This reduces > the number of arguments and saves 48 bytes from fs/fcntl.o. Ok, I know I asked for this, but now I suddenly start worrying about whether f_owner.uid/euid are initialized at all for the pid==NULL case? They used to be initialized to zero, now they are left alone. Are they initialized somewhere else earlier? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/