Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753824AbZFQETZ (ORCPT ); Wed, 17 Jun 2009 00:19:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750886AbZFQETP (ORCPT ); Wed, 17 Jun 2009 00:19:15 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:60680 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbZFQETO (ORCPT ); Wed, 17 Jun 2009 00:19:14 -0400 Date: Tue, 16 Jun 2009 21:19:11 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Andrew Patterson cc: linux-pci@vger.kernel.org, Linux Kernel Mailing List , jbarnes@virtuousgeek.org, Ivan Kokshaysky Subject: Re: [PATCH 0/1] Recurse when searching for empty slots in resources trees In-Reply-To: <1245208744.19708.243.camel@grinch> Message-ID: References: <20090616220419.14021.84524.stgit@bob.kio> <1245192703.8234.226.camel@bluto.andrew> <1245195498.8234.236.camel@bluto.andrew> <1245208744.19708.243.camel@grinch> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 27 On Wed, 17 Jun 2009, Andrew Patterson wrote: > > This looks functionally equivalent to the current code. Absolutely. It's only meant to add the call chains for all the resource additions, so that we could see how that buggy 'c2' resource gets added as a parent to 'c3' (when it should be the other way around). > I get way too much output to be useful. I can log the serial port if we > need it all, or I can change it to just look at the buses in question if > desired. Sure. Or increase CONFIG_LOG_BUF_SHIFT to 22 or somethng insane like that (so that it logs up to 4MB of messages). But yeah, if you just make it smarter, and only do that WARN() thing for resources that match "PCI Bus" at the beginning of the name, that should be plenty good enough. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/