Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754428AbZFQFvG (ORCPT ); Wed, 17 Jun 2009 01:51:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753689AbZFQFu4 (ORCPT ); Wed, 17 Jun 2009 01:50:56 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:42513 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbZFQFuz (ORCPT ); Wed, 17 Jun 2009 01:50:55 -0400 Subject: Re: MCE boot crash in qemu From: Pekka Enberg To: Andi Kleen Cc: Vegard Nossum , Ingo Molnar , LKML In-Reply-To: <1245072122.23207.47.camel@penberg-laptop> References: <19f34abd0906150459v2eb6fd1ak86586bc697c1e69f@mail.gmail.com> <20090615125200.GD31969@one.firstfloor.org> <1245072122.23207.47.camel@penberg-laptop> Date: Wed, 17 Jun 2009 08:50:56 +0300 Message-Id: <1245217856.5604.16.camel@penberg-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-Mailer: Evolution 2.24.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 901 Lines: 25 On Mon, 2009-06-15 at 16:22 +0300, Pekka Enberg wrote: > On Mon, 2009-06-15 at 14:52 +0200, Andi Kleen wrote: > > x86: mce: Handle banks == 0 case in K7 quirk > > > > This happens on QEMU which reports MCA capability, but no banks. > > Without this patch there is a buffer overrun and boot ops because the code > > would try to initialize the 0 element of a zero length kmalloc() > > buffer. > > > > Signed-off-by: Andi Kleen > > This fixes the bug for me! > > Tested-by: Pekka Enberg Ingo, I hit this again in my testing after rebasing to linus/master so I really would like this in mainline. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/