Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765483AbZFQK2h (ORCPT ); Wed, 17 Jun 2009 06:28:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765141AbZFQK2L (ORCPT ); Wed, 17 Jun 2009 06:28:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51268 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764905AbZFQK2I (ORCPT ); Wed, 17 Jun 2009 06:28:08 -0400 Date: Wed, 17 Jun 2009 12:28:10 +0200 From: Nick Piggin To: Jan Kara Cc: LKML , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 01/11] ext3: Get rid of extenddisksize parameter of ext3_get_blocks_handle() Message-ID: <20090617102810.GA29931@wotan.suse.de> References: <1245088797-29533-1-git-send-email-jack@suse.cz> <1245088797-29533-2-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1245088797-29533-2-git-send-email-jack@suse.cz> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 20 On Mon, Jun 15, 2009 at 07:59:48PM +0200, Jan Kara wrote: > Get rid of extenddisksize parameter of ext3_get_blocks_handle(). This seems to > be a relict from some old days and setting disksize in this function does not > make much sence. Currently it was set only by ext3_getblk(). Since the > parameter has some effect only if create == 1, it is easy to check that the > three callers which end up calling ext3_getblk() with create == 1 (ext3_append, > ext3_quota_write, ext3_mkdir) do the right thing and set disksize themselves. > > Signed-off-by: Jan Kara I guess something like this should just go in this merge window if ext3 developers are happy with it? There is no real reason to keep it with the main patchset is there? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/