Date: Wed, 17 Jun 2009 04:35:34 -0700 (PDT)
Message-Id: <20090617.043534.259824726.davem@davemloft.net>
To: mingo@elte.hu
Cc: eric.dumazet@gmail.com, tglx@linutronix.de, torvalds@linux-foundation.org,
       akpm@linux-foundation.org, netdev@vger.kernel.org,
       linux-kernel@vger.kernel.org, kaber@trash.net
Subject: Re: [bug] __nf_ct_refresh_acct(): WARNING: at lib/list_debug.c:30
 __list_add+0x7d/0xad()
From: David Miller <davem@davemloft.net>
In-Reply-To: <20090617110803.GA10175@elte.hu>
References: <20090617092152.GA17449@elte.hu>
	<4A38C2F3.3000009@gmail.com>
	<20090617110803.GA10175@elte.hu>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 870
Lines: 24

From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 17 Jun 2009 13:08:03 +0200

> 
> * Eric Dumazet <eric.dumazet@gmail.com> wrote:
> 
>> IPS_CONFIRMED_BIT is set under nf_conntrack_lock (in __nf_conntrack_confirm()),
>> we probably want to add a synchronisation under ct->lock as well,
>> or __nf_ct_refresh_acct() could set ct->timeout.expires to extra_jiffies,
>> while a different cpu could confirm the conntrack.
>> 
>> Following patch as RFC
> 
> A quick test suggests that it seems to works here - thanks Eric!

Patrick, please take a quick look at Eric's fix.  I'd like to
apply it quickly if it looks good to you.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/