Message-ID: <4A39056E.1060409@novell.com>
Date: Wed, 17 Jun 2009 11:02:06 -0400
From: Gregory Haskins <ghaskins@novell.com>
User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
MIME-Version: 1.0
To: "Michael S. Tsirkin" <mst@redhat.com>
CC: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, avi@redhat.com,
       davidel@xmailserver.org, paulmck@linux.vnet.ibm.com, mingo@elte.hu
Subject: Re: [KVM-RFC PATCH 1/2] eventfd: add an explicit srcu based	notifier
 interface
References: <20090616140240.GA9401@redhat.com> <4A37A7FC.4090403@novell.com> <20090616143816.GA18196@redhat.com> <4A37B0BB.3020005@novell.com> <20090616145502.GA1102@redhat.com> <4A37B832.6040206@novell.com> <20090616154150.GA17494@redhat.com> <4A37C592.2030407@novell.com> <20090616175300.GA24514@redhat.com> <4A37DFE2.2020506@novell.com> <20090617144540.GB3089@redhat.com>
In-Reply-To: <20090617144540.GB3089@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigDDD3AF2F764143F9EEFAF200"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2150
Lines: 61

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigDDD3AF2F764143F9EEFAF200
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Michael S. Tsirkin wrote:
> On Tue, Jun 16, 2009 at 02:09:38PM -0400, Gregory Haskins wrote:
>  =20
>>> What do you mean by copy_to_user(other->mm) here?  If you are going t=
o switch
>>> to another mm, then I think current->mm must be valid (I think it's n=
ot enough
>>> that you can sleep). So preemptible() might not be enough.
>>>  =20
>>>      =20
>> I dont currently use switch_mm, if that is what you mean.  I save the
>> task_struct into the appropriate context so current->mm doesn't matter=

>> to me.  I never use it.  All I need (afaik) is to acquire the proper
>> mutex first.  I am not an MM expert, so perhaps I have this wrong but =
it
>> does appear to work properly even from kthread context.
>>
>> -Greg
>>
>>
>>    =20
>
> I think I saw get_user_pages + memcpy in your patch. Yes, that works
> without switching contexts but it's slower than copy to user if you are=

> in the right context, and AFAIK it's slower than get_user_pages_fast.
>
>  =20
Yeah, understood.  It will definitely be interesting to try that
optimization with switch_mm that you suggested.

On that front, would "if (p =3D=3D current)" still work even if we don't
have the "signal_task()" hint?


--------------enigDDD3AF2F764143F9EEFAF200
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAko5BW4ACgkQlOSOBdgZUxlYcwCfYZlf3sPhQTnRRkJc/cViUMGu
FmUAmwU/Bx7S2G5AxfyRY0BXTD6wGskI
=U7oT
-----END PGP SIGNATURE-----

--------------enigDDD3AF2F764143F9EEFAF200--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/